Skip to content

Conversation

@Wolf3s
Copy link

@Wolf3s Wolf3s commented Sep 2, 2024

This pr superceeds #1
credits: @7dog123 for the first port.

derselbst and others added 22 commits December 29, 2023 13:06
Keep GitHub Actions up to date with GitHub's Dependabot
Bumps the github-actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [github/codeql-action](https://github.com/github/codeql-action).


Updates `actions/checkout` from 3 to 4
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

Updates `github/codeql-action` from 2 to 3
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
…actions/github-actions-67979dcedc

Bump the github-actions group with 2 updates
@Wolf3s
Copy link
Author

Wolf3s commented Sep 2, 2024

cmake -S . -B build "-DCMAKE_TOOLCHAIN_FILE=${PS2DEV}/share/ps2dev.cmake" "-DCMAKE_INSTALL_PREFIX=${PS2SDK}/ports" -Denable=aufile=OFF -DBUILD_SHARED_LIBS=OFF -Denable-dbus=OFF -Denable-ipv6=OFF -Denable-jack=OFF -Denable-libinstpatch=OFF -Denable-libsndfile=OFF -Denable-midishare=OFF -Denable-network=ON -Denable-oss=OFF -Denable-dsound=OFF -Denable-wasapi=OFF -Denable-waveout=OFF -Denable-winmidi=OFF -Denable-sdl2=ON -Denable-pulseaudio=OFF -Denable-pipewire=OFF -Denable-readline=OFF -Denable-threads=ON -Denable-openmp=OFF

@fjtrujy
Copy link
Member

fjtrujy commented Oct 14, 2024

Can you please revert all the cosmetic changes and changes totally unrelated to the PS2 port?
it will help us to keep track of all the specific required changes.

@Wolf3s
Copy link
Author

Wolf3s commented Oct 14, 2024

Can you please revert all the cosmetic changes and changes totally unrelated to the PS2 port? it will help us to keep track of all the specific required changes.

Well then, I should deprecate this one and use sed patch on ps2sdk-ports for achive that.

@Wolf3s Wolf3s closed this Oct 14, 2024
@fjtrujy
Copy link
Member

fjtrujy commented Oct 14, 2024

I was fine with the port, but we should keep the changes as small as possible.
I have the impression that tons of the changes we have here can be skipt with some specific boolean flags.
I don't think that having a sed on ps2sdk-ports will make things easier to follow honestly

@Wolf3s
Copy link
Author

Wolf3s commented Oct 14, 2024

I was fine with the port, but we should keep the changes as small as possible. I have the impression that tons of the changes we have here can be skipt with some specific boolean flags. I don't think that having a sed on ps2sdk-ports will make things easier to follow honestly

Well it's only three stuff changed also there are some specific ones that needs to open a PR to remove inside like glib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants