sio2man changes 28032025 #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What's the purpose of all these callbacks that are always called? |
Member
Author
|
It will basically avoid a branch for checking if the callback pointer is NULL, since it is always set to something |
Member
|
@uyjulian using Can you take a look at this? references: Also note the issue comment I left here: #718 |
2 tasks
This was referenced Jun 14, 2025
362053534
pushed a commit
to 362053534/ps2sdk
that referenced
this pull request
Aug 3, 2025
sio2man changes 28032025
362053534
added a commit
to 362053534/ps2sdk
that referenced
this pull request
Aug 3, 2025
…8032025" This reverts commit 5c3fc32.
362053534
pushed a commit
to 362053534/ps2sdk
that referenced
this pull request
Aug 3, 2025
sio2man changes 28032025
362053534
pushed a commit
to 362053534/ps2sdk
that referenced
this pull request
Aug 3, 2025
sio2man changes 28032025
362053534
pushed a commit
to 362053534/ps2sdk
that referenced
this pull request
Aug 4, 2025
sio2man changes 28032025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.