Skip to content

sysclib/ctype: add extern declaration for look_ctype_table in header#815

Merged
uyjulian merged 1 commit intops2dev:masterfrom
fjtrujy:clean_sysclib
Mar 6, 2026
Merged

sysclib/ctype: add extern declaration for look_ctype_table in header#815
uyjulian merged 1 commit intops2dev:masterfrom
fjtrujy:clean_sysclib

Conversation

@fjtrujy
Copy link
Copy Markdown
Member

@fjtrujy fjtrujy commented Mar 6, 2026

Add extern const unsigned char *look_ctype_table(void); to iop/system/sysclib/include/ctype.h so the header is self-contained. This prevents implicit-function-declaration warnings on strict builds and avoids prototype/ABI mismatches.

Files: iop/system/sysclib/include/ctype.h, iop/system/sysclib/include/sysclib.h, iop/system/sysclib/src/nonstd/ctype.c

Add `extern const unsigned char *look_ctype_table(void);` to `iop/system/sysclib/include/ctype.h` so the header is self-contained. This prevents implicit-function-declaration warnings on strict builds and avoids prototype/ABI mismatches.

Files: iop/system/sysclib/include/ctype.h, iop/system/sysclib/include/sysclib.h, iop/system/sysclib/src/nonstd/ctype.c
@fjtrujy fjtrujy requested a review from uyjulian March 6, 2026 15:26
Copy link
Copy Markdown
Member

@uyjulian uyjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@uyjulian uyjulian merged commit 41e0af1 into ps2dev:master Mar 6, 2026
3 checks passed
@fjtrujy fjtrujy deleted the clean_sysclib branch March 6, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants