CI improvements 20250918 #25

uyjulian · 2025-09-19T23:24:29Z

Notable improvements are running in a older Ubuntu container for compatibility improvements, and arm64 support for the Docker/OCI container

fjtrujy · 2025-09-20T09:49:54Z

.github/workflows/docker.yml

+      DISPATCH_TOKEN: ${{ secrets.DISPATCH_TOKEN }}
+    strategy:
+      matrix:
+        dest-repo: [ps2toolchain, ps2sdk, ps2sdk-ports, ps2-packer, ps2dev, gsKit, ps2link, ps2homebrew/ps2dev_forwarder]


Why are we dispatching to all repos? Shouldn't we follow the same approach as before?

This won't actually dispatch to all repos (see the exclude: key).

fjtrujy

Not sure if I follow your changes, do you want to do the same workflow for all the repositories?

fjtrujy · 2025-09-20T09:54:00Z

scripts/001-binutils.sh

-    echo Macport base is $MACPORT_BASE
+    MACPORT_BASE=$(dirname $(port -q contents gmp|grep gmp.h)|sed s#/include##g)
+    printf 'Macport base is %s\n' "$MACPORT_BASE"
+    alias sed='gsed'


Is this really needed?
Unless it is necessary for ps2toolchain-ee, the IOP one compiled successfully without that. I know that for brew it was needed

fjtrujy · 2025-09-20T09:56:22Z

.github/workflows/compilation.yml

+    container:
+      image: ${{ matrix.os.container }}
+      options: ${{ matrix.os.container-options }}
+    timeout-minutes: 240


why are you setting timeout? I think it doesn't make sense in our scenario

This is in case the build hangs (e.g. stuck at prompt or stuck in infinite retry loop) it will allow to notice earlier. Github default runners have a maximum timeout of 6 hours, so I reduced it to 4 hours.

fjtrujy · 2025-09-20T10:00:36Z

.github/workflows/compilation.yml

            shell: bash
-            packageManager: default
-          - machine: ubuntu-22.04-arm
+            container: "ubuntu:20.04"


I don't get why you use Docker inside of Ubuntu, and you actually use the OS version 20.04, which reduces compatibility, as the precompiled toolchain can't be used in modern versions.

I could understand using Docker for those OS GHA doesn't offer as VM, like for instance Fedora, but I don't get your current approach

This actually increases compatibility, as stuff built on 20.04 also works on 22.04 and 24.04.

But on the other hand, we loose the visibility of checking if the toolchain works with "actual & more used" Ubuntu version, which is 24.04...

If it would be only for command line/server users then I would agree.
However, I think this helps more with desktop/graphical users as they may be lagging behind on the distribution version due to desktop environment, driver, or other related issues. This is probably the situation where more people would want to run the precompiled toolchain on their system.
If needed, in the future more configurations could be added.

uyjulian · 2025-09-20T11:11:15Z

Not sure if I follow your changes, do you want to do the same workflow for all the repositories?

Affirmative.

fjtrujy

The thing that I don't like in general is the fact that now we have references to IOP, EE, GSKIT, and others in this DVP toolchain repo.
I know that the main reason was to keep files as few as possible, but honestly, I'm not sure if it brings more pros than cons.

Have you thought about getting some of these values from variables in the repo configuration? In this way we can keep the YML simpler and the same for every single repo, where the differences are on the "variables section" within the config of the repo

uyjulian · 2025-09-20T11:33:07Z

I'll put the export variables and the repository dispatch variables in a separate JSON file in this PR later.

Sync changes with other repo Separate repository dispatch into another job Add ARM build

Merge changes from other repo Run in ubuntu 20.04 container for ubuntu runner Add 4 hour timeout use standardized printf instead of echo Only add gnu-sed to path if brew available Correct archive name Avoid Homebrew additional network stuff

…ad backtick

uyjulian · 2025-09-20T14:33:52Z

Made the changes. Environment is now set up in a separate file and repository dispatch variables are now placed in a separate file.

fjtrujy · 2025-10-04T09:54:02Z

Ok, let's see how it is working!

fjtrujy reviewed Sep 20, 2025

View reviewed changes

uyjulian force-pushed the ci_improvements_20250918 branch from 3829060 to 8b2fa4b Compare September 20, 2025 11:15

fjtrujy reviewed Sep 20, 2025

View reviewed changes

uyjulian added 3 commits September 20, 2025 08:54

CI: improve docker CI

a011acf

Sync changes with other repo Separate repository dispatch into another job Add ARM build

CI: improve compilation CI

b65b326

Merge changes from other repo Run in ubuntu 20.04 container for ubuntu runner Add 4 hour timeout use standardized printf instead of echo Only add gnu-sed to path if brew available Correct archive name Avoid Homebrew additional network stuff

buildsystem: Use printf instead of echo, use dollar shell subst inste…

3ad829a

…ad backtick

uyjulian force-pushed the ci_improvements_20250918 branch from 4092326 to 3ad829a Compare September 20, 2025 13:54

fjtrujy merged commit 43c3224 into ps2dev:main Oct 4, 2025
7 checks passed

CI improvements 20250918 #25

CI improvements 20250918 #25

Uh oh!

Conversation

uyjulian commented Sep 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fjtrujy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uyjulian commented Sep 20, 2025

Uh oh!

fjtrujy left a comment

Choose a reason for hiding this comment

Uh oh!

uyjulian commented Sep 20, 2025

Uh oh!

uyjulian commented Sep 20, 2025

Uh oh!

fjtrujy commented Oct 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants