Skip to content

Commit 461a525

Browse files
psaegertclaude
andcommitted
Style: the flake8 findings in the canonicalization commit
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MktGcCWQs8zePRutL56sT4
1 parent f41fe6b commit 461a525

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

src/flash_ansr/flash_ansr.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,6 @@ def canonicalize_fitted(simplipy_engine: Any, refiner: Refiner, expression: Sequ
277277
return carried, canonical, True, values.size == old_values.size
278278

279279

280-
281280
def _serialize_fits(refiner: Refiner) -> list[tuple[np.ndarray, np.ndarray | None, float]]:
282281
serialized: list[tuple[np.ndarray, np.ndarray | None, float]] = []
283282
for constants, constants_cov, fit_loss in refiner._all_constants_values:

tests/test_canonical_fitted.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ def _fit(engine, expression, X, y, p0):
2323

2424
def test_a_factor_that_cancels_once_fitted_is_dropped(engine):
2525
rng = np.random.default_rng(0)
26-
X = rng.uniform(-3, 3, (64, 1)); y = np.exp(-X[:, 0] ** 2)
26+
X = rng.uniform(-3, 3, (64, 1))
27+
y = np.exp(-X[:, 0] ** 2)
2728
expression = "/ * exp neg pow x1 <constant> pow tanh x1 <constant> pow tanh x1 <constant>".split()
2829
fitted = _fit(engine, expression, X, y, [2.0, 2.0, 2.0])
2930
carried, canonical, changed, same_slots = canonicalize_fitted(engine, fitted, expression, X, n_variables=1)
@@ -36,7 +37,8 @@ def test_a_factor_that_cancels_once_fitted_is_dropped(engine):
3637

3738
def test_constants_fold_into_one_slot(engine):
3839
rng = np.random.default_rng(1)
39-
X = rng.uniform(-3, 3, (64, 1)); y = 6.0 * X[:, 0]
40+
X = rng.uniform(-3, 3, (64, 1))
41+
y = 6.0 * X[:, 0]
4042
expression = ["*", "<constant>", "*", "<constant>", "x1"]
4143
fitted = _fit(engine, expression, X, y, [2.0, 3.0])
4244
carried, canonical, changed, same_slots = canonicalize_fitted(engine, fitted, expression, X, n_variables=1)
@@ -50,7 +52,8 @@ def test_a_respelling_is_not_a_collapse(engine):
5052
"""The canon writes an exact 1.5 as 3/2 (`/ * 3 sin x1 2`): longer, a different slot structure, the
5153
ladder's business -- the fitted spelling stays."""
5254
rng = np.random.default_rng(2)
53-
X = rng.uniform(-3, 3, (64, 1)); y = 1.5 * np.sin(X[:, 0])
55+
X = rng.uniform(-3, 3, (64, 1))
56+
y = 1.5 * np.sin(X[:, 0])
5457
expression = ["*", "<constant>", "sin", "x1"]
5558
fitted = _fit(engine, expression, X, y, [1.5])
5659
assert list(engine.simplify(["*", "1.5", "sin", "x1"])) == ["/", "*", "3", "sin", "x1", "2"]
@@ -60,7 +63,8 @@ def test_a_respelling_is_not_a_collapse(engine):
6063

6164
def test_an_equal_length_respelling_is_left_to_the_ladder(engine):
6265
rng = np.random.default_rng(4)
63-
X = rng.uniform(0.5, 3, (64, 1)); y = np.sqrt(X[:, 0])
66+
X = rng.uniform(0.5, 3, (64, 1))
67+
y = np.sqrt(X[:, 0])
6468
expression = ["pow", "x1", "<constant>"]
6569
fitted = _fit(engine, expression, X, y, [0.5])
6670
_, canonical, changed, _ = canonicalize_fitted(engine, fitted, expression, X, n_variables=1)
@@ -69,7 +73,8 @@ def test_an_equal_length_respelling_is_left_to_the_ladder(engine):
6973

7074
def test_the_worker_emits_the_canonical_member(engine):
7175
rng = np.random.default_rng(3)
72-
X = rng.uniform(-3, 3, (64, 1)); y = np.exp(-X[:, 0] ** 2)
76+
X = rng.uniform(-3, 3, (64, 1))
77+
y = np.exp(-X[:, 0] ** 2)
7378
payload = {
7479
"simplipy_engine": engine,
7580
"expression": "/ * exp neg pow x1 <constant> pow tanh x1 <constant> pow tanh x1 <constant>".split(),

0 commit comments

Comments
 (0)