Open
Conversation
|
@pseudomuto We would really appreciate it if you could merge this PR. We are using @nvx fork for now, but it would make our lives easier if we could just use the upstream. I maintain a fair amount of open source projects on a volunteer basis, so I know how hard it can be to keep up with this stuff. Let me know if I can help. |
|
@pseudomuto +1 on this issue, would be great if this were merged 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for buf validate https://github.com/bufbuild/protovalidate
Alternative the master branch at https://github.com/nvx/protoc-gen-doc/tree/master has this and some other fixes to unit tests and version bumps (I note the version of golang.org/x/crypto in the go.mod has outstanding CVEs, unit tests fail on Windows, and it's using a long out of support version of Go) and could be merged instead.