Skip to content

tests: explicitly GC for PyPy in test_do_not_leak_response #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woodruffw merged 1 commit into from
Jan 9, 2025
Merged

tests: explicitly GC for PyPy in test_do_not_leak_response #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/test_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# SPDX-License-Identifier: Apache-2.0

import gc
import platform
import weakref
from unittest import mock

Expand Down Expand Up @@ -82,6 +83,12 @@ def test_do_not_leak_response(self, url, sess):
# We should not break this.

resp = None
if platform.python_implementation() == "PyPy":
# NOTE: Need to explicitly tell PyPy to collect at this point.
# See: https://github.com/psf/cachecontrol/issues/351
# See: https://doc.pypy.org/en/latest/cpython_differences.html#differences-related-to-garbage-collection-strategies
gc.collect()

# Below this point, it should be closed because there are no more references
# to the session response.

Expand Down
Loading