-
Notifications
You must be signed in to change notification settings - Fork 169
Creating libpspgud library
#320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sharkwouter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can still test this and look into it more deeply, but since there is no code in here that will break existing code, this can be safely merged.
No problem, take your time |
| gu_settings.swapBuffersCallback = NULL; | ||
| gu_settings.swapBuffersBehaviour = PSP_DISPLAY_SETBUF_NEXTHSYNC; | ||
|
|
||
| gu_init = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a getter for this one at some point. Maybe not in this PR, though.
|
There are a couple of places where modulo (%) is used. This is quite heavy on the PSP. Is there maybe an alternative possible? I know this is not a place to care about performance, though. |
I think they can be replaced with |
- Adding assertions to each specific sceGu function - Also adding printf for verbose output
I have replaced with |
Description
This PR creates a
libpspgud.alibrary. This library is identical tolibpspgu.a, differing only in the inclusion of numerous assertions andprintfcalls.This is quite useful for debugging purposes, as it easily reveals if you're doing something not allowed.
It is also it is useful to identify what kind of values are going to be added into the GPU queue.
I'm not sure if some assertions are wrong or some of them are missing, so please, take a look to them.
Cheers.