Skip to content

document trading hours#1604

Merged
bug-or-feature merged 3 commits intopst-group:developfrom
bug-or-feature:feature-1573-document-trading-hours
Feb 24, 2026
Merged

document trading hours#1604
bug-or-feature merged 3 commits intopst-group:developfrom
bug-or-feature:feature-1573-document-trading-hours

Conversation

@bug-or-feature
Copy link
Member

@bug-or-feature bug-or-feature commented Feb 24, 2026

Fix for #1573

  • mentions trading hours in pre-trade checks
  • adds sample output for "View trading hours for all instruments" from Interactive diagnostics
  • re-orders docs for Interactive diagnostics sub functions to match script
  • adds a section on "Trading hours configuration" under Production system concepts > Configuration files

Can someone who uses custom trading hours review this please? I'm UK based so just use the defaults

@tgibson11
Copy link
Contributor

What you have looks good to me.

I would suggest also adding something higher up, maybe in the Quick Start Guide - because the default config will not work for anyone not in GMT.

Anyone not in GMT must do both of the following for production trading:

  • Update GMT_offset_hours based on your local timezone
  • Update the per-timezone trading hours. The simplest way to do that is to add (or subtract) your GMT offset from the default times. Keep in mind that the start time always has be before the end time, which means in some cases you might want two sessions per day if the trading hours would span midnight. See the instrument-specific examples for how to configure multiple sessions per day.

@bug-or-feature
Copy link
Member Author

What you have looks good to me.

I would suggest also adding something higher up, maybe in the Quick Start Guide - because the default config will not work for anyone not in GMT.

Anyone not in GMT must do both of the following for production trading:

  • Update GMT_offset_hours based on your local timezone
  • Update the per-timezone trading hours. The simplest way to do that is to add (or subtract) your GMT offset from the default times. Keep in mind that the start time always has be before the end time, which means in some cases you might want two sessions per day if the trading hours would span midnight. See the instrument-specific examples for how to configure multiple sessions per day.

@tgibson11 thanks Todd, done

@bug-or-feature bug-or-feature merged commit d2c03c0 into pst-group:develop Feb 24, 2026
2 checks passed
@bug-or-feature bug-or-feature deleted the feature-1573-document-trading-hours branch March 4, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants