Enhance the ParsedValue.value setter to correctly update object attributes#23
Open
paul356 wants to merge 1 commit intopsychogenic:mainfrom
Open
Enhance the ParsedValue.value setter to correctly update object attributes#23paul356 wants to merge 1 commit intopsychogenic:mainfrom
paul356 wants to merge 1 commit intopsychogenic:mainfrom
Conversation
Author
|
@psychogenic Hi Pat. Do you have time to review this enhancement? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes we may want to add a new attribute to a node by assign a sexpdata tree to .value. But the fields are not updated according to the new value. For example _value and children is not updated which may causes problem if further operations depend on these fields.
This enhancement is to enhance the ParsedValue.value setter to update the fields according to assignee. I have verified the new function by adding a hide = yes attribute to a property string. The test code is like.