This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Change hashed-string input type from text to hidden #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hashed-string is a concatenation of all key-value pairs which are used to calculate the content hash (fingerprint). It is added to the form and used by the server for additional integrity checks. Because one of the fields (Weitere Anmerkungen) is a textarea, it could contain newlines, and hence the hashed-string could also contain newlines. These would get stripped when entered (via JavaScript) into the text field, causing integrity check failures on the server. Apparently, this does not happen for input type=hidden (which also does not need the style parameter to make it hidden). https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/hidden Fixes #44
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hashed-string is a concatenation of all key-value pairs which are used to calculate the content hash (fingerprint). It is added to the form and used by the server for additional integrity checks. Because one of the fields (Weitere Anmerkungen) is a textarea, it could contain newlines, and hence the hashed-string could also contain newlines. These would get stripped when entered (via JavaScript) into the text field, causing integrity check failures on the server. Apparently, this does not happen for input type=hidden (which also does not need the style parameter to make it hidden).
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/hidden
Fixes #44