Skip to content

Add support for depth confidence #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
hobinjk-ptc wants to merge 464 commits into
base: main
Choose a base branch
from
Draft

Add support for depth confidence #86

hobinjk-ptc wants to merge 464 commits into from

Conversation

@hobinjk-ptc
Copy link
Contributor

@hobinjk-ptc hobinjk-ptc commented Feb 9, 2023

Each depth pixel now has a confidence level encoded in its highest bit.

benptc and others added 30 commits April 27, 2022 12:36
@benptc
begin to identify which segments are selected by the playhead and out…
2aae593 
…put which piece of data is at that timestamp in each of the tracks/segments
@benptc
synchronize menu toggle state with actual toggle state for history li…
125d2bb 
…nes, point clouds
@benptc
Merge pull request #23 from ptcrealitylab/menu-state-fix
7c68830 
fix toggle states for several menu buttons
@hobinjk-ptc
Fade out depth visualization between 4-5 meters, hiding anything further
2acde74
@benptc
change depth fadeout range to 4.5-5.0 meters
dffe105
@benptc
Merge pull request #24 from ptcrealitylab/dr-fade
1ee2f2b 
Fade out depth visualization between 4-5 meters, hiding anything further
@hobinjk-ptc
Improve clarity of alphaDepth calculation
054de9b
@hobinjk-ptc
Merge remote-tracking branch 'origin/depth-representation' into cloud…
669f98c 
…-edition
@hobinjk-ptc
Work around race causing missing keyboard implementation
97bef62
@hobinjk-ptc
Hide virtual camera error behind DEBUG
28d1afa
@hobinjk-ptc
Be more careful about interactionCursor
bdd6c25
@hobinjk-ptc
Try bringing back modules
32491ec
@benptc
first implementation of video elements, playback
a832e7d
@benptc
correctly hide point cloud when video playback ends
02ec2b7
@benptc
lots of edge case cleanup for timeline
f638302
@hobinjk-ptc
Document everything happening in the fragment shader
cbb729d
@benptc
restyle timeline with greyscale borderless theme
8d103c3
@benptc
Merge branch 'depth-representation' into pointcloud-playback
17ea3d2
@benptc
cleanup, comment, refactor timeline and video playback code
146b7fa
@benptc
remove conflicting model texture toggle
abb29a1
@benptc
respond to reviewer comments
da2472c
@benptc
Merge pull request #25 from ptcrealitylab/pointcloud-playback
d9a51bf 
3D Video Playback Timeline
@hobinjk-ptc
Hide camera mesh when it would obscure the RO view; Refactor camera v…
4583f71 
…is matrix update
@hobinjk-ptc
Adjust depth max representable distance to 5 meters
3d18818
@hobinjk-ptc
Add support for color+depth over webrtc
ef1966b
@benptc
env var to hide occlusion mesh on remote operator
4f3a169
@hobinjk-ptc
Merge remote-tracking branch 'origin/dr-webrtc' into cloud-edition
8b71917
@hobinjk-ptc
Add support for color+depth over webrtc
9824b62
@hobinjk-ptc
Maybe connect signalling through cloud-edge
138cae2
@hobinjk-ptc
Fix text transcoding; Add missing messages
e76ab33
benptc and others added 26 commits November 30, 2022 18:52
@benptc
fixup spaghettiMeshPath
216d168
@benptc
address reviewer comments
38b26b4
@benptc
Merge pull request #81 from ptcrealitylab/mesh-path
f5293fd 
SpaghettiMeshPath for historyLines
@benptc
sets cone center and direction based on CameraVis
b8d81f2
@benptc
passes frustum planes to area target shader
c0266d4
@benptc
properly interact with frustum shader
81028cb
@benptc
begin refactor
8820531
@benptc
cleanup multiple culling frustums
49edadc
@benptc
properly remove frustum when cameravis disconnects
4b69173
@benptc
Merge pull request #82 from ptcrealitylab/shader-frustum-refactor
7bbadb2 
Utilize area target frustum culling shader
@hobinjk-ptc
Adjust z offset based on fraction of depth in addition to baseline
0e8e1c7
@hobinjk-ptc
Add support for depthMin and depthMax uniforms
eb4054f
@hobinjk-ptc
Add green border to CameraVis pointclouds
790e403
@hobinjk-ptc
Add proof-of-concept overwrought patch loading animation
09f1792
@hobinjk-ptc
Trim trailing whitespace
a6e64c5
@hobinjk-ptc
Add Visual Diff lens and ability to switch camera lenses
d121695
@hobinjk-ptc
Only swap canvas dimensions when necessary
2fe7354
@hobinjk-ptc
Remove most of depth adjustment
933f65e
@hobinjk-ptc
Remove alphaDepth adjustment
c1ae58d
@hobinjk-ptc
Speed up patch loading animation
4de4e42
@benptc @hobinjk-ptc
CameraVis stores maxDepthMeters on each update
a775173
@Steve-KX-RL
Add "delete all tools" function in the Developer Menu
936375a
@Steve-KX-RL
Add a flying camera
4ff83c9 
- camera follows mouse
- WASDQE - move
- Shift - Speed up
@Steve-KX-RL
Merge branch 'main' of https://github.com/ptcrealitylab/vuforia-spati…
6e58d84 
…al-remote-operator-addon
@hobinjk-ptc
Add mute/unmute to WebRTCCoordinator; Keep reference to WebRTCCoordin…
4d31351 
…ator in CameraVisCoordinator
@hobinjk-ptc
Add support for depth confidence
c9b3475 
Each depth pixel now has a confidence level encoded in its highest bit.
@hobinjk-ptc
Copy link
Contributor Author

hobinjk-ptc commented Feb 9, 2023

See also: https://github.com/ptcrealitylab/vuforia-spatial-toolbox-ios-swift/pull/276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hobinjk-ptc @benptc @dangond-ptc @Steve-KX-RL