Fix: Prevent laravel/sanctum from going beyond version 4.2.4#5591
Open
ollieread wants to merge 1 commit intopterodactyl:1.0-developfrom
Open
Fix: Prevent laravel/sanctum from going beyond version 4.2.4#5591ollieread wants to merge 1 commit intopterodactyl:1.0-developfrom
ollieread wants to merge 1 commit intopterodactyl:1.0-developfrom
Conversation
|
Woudn't be "easier" to fix the issue ? Or you prefer not ? |
Author
@WeeskyBDW the issue is that Pterodactyl has a bit of a hack around this part and fixing the cause of it would require most likely a chunk of work. Locking the version like this is the quickest way to not break everyone's api keys if they get a later version of sanctum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If anyone runs any form of composer update they'll get
laravel/sanctumversion4.3.1, but4.3.0introduced a breaking change that will cause errors in Pterodactyl installs.In
\Pterodactyl\Extensions\Laravel\Sanctum\NewAccessTokenyou're relying on the underlying class' (\Laravel\Sanctum\NewAccessToken) lack of typing on theaccessTokenproperty. In Laravel Sanctum4.3.0the laravel/sanctum#586 PR changes were released, which refactors the underlying class to use property promotion, and specifies a type.https://github.com/laravel/sanctum/blob/224864063d51d6adddc8c061ccf61eafa0e8f7ce/src/NewAccessToken.php#L10-L18