[BOX64][INTERP] Fixed idiv boundary tests #3281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luoqiaoling
commented
Dec 16, 2025
luoqiaoling
commented
- related test case: tests/test33
- related test case: tests/test33
ksco
requested changes
Dec 16, 2025
Collaborator
ksco
left a comment
ksco
left a comment
There was a problem hiding this comment.
Thanks for the PR, but to make it easier for collaborators worldwide to understand, could you please change the comments in test33.c to English?
Collaborator
There was a problem hiding this comment.
Please remove the Chinese comments in this file, or translate them into English.
Collaborator
There was a problem hiding this comment.
This test needs to be added to CMakeLists.txt for ctest to pick it up.
Collaborator
|
Please don't delete the branch when the PR it connects to is still pending, as this will close that PR. You will have to open a new PR, leaving all the review comments here in the closed one. You should push or force-push to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.