Merged
Conversation
…hould result in much faster event handling when handlers expect references to the event arguments. Downside is this change is a breaking change and likely requires a major version update. other changes: noexcept correctness use scoped_lock over unique_lock
Owner
|
I like the direction this is going, but will these changes require C++20 now? |
Contributor
Author
|
I don't believe so -- you have the std set to 17 in the main cmakelists.txt and it all compiled. some older compilers may have issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a fix for #38 such that if an event handler expects a reference to the event, it is given one without making a copy.
R-value references and value type parameters are handed copies.
This is also technically a breaking change, as EventTypes are now inferred by the event handler function traits, which will break current implementations but for the better.