Unified eventbus impl for any and variant storage types#41
Merged
ptsouchlos merged 11 commits intodevelopfrom Apr 7, 2025
Merged
Unified eventbus impl for any and variant storage types#41ptsouchlos merged 11 commits intodevelopfrom
eventbus impl for any and variant storage types#41ptsouchlos merged 11 commits intodevelopfrom
Conversation
Added policies to be able to switch between std::any and std::variant as the storage type inside the event bus.
Also added new project options as well to better control what gets build.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (11)
- CMakeLists.txt: Language not supported
- CMakePresets.json: Language not supported
- benchmark/CMakeLists.txt: Language not supported
- benchmark/src/event_bus.cpp: Language not supported
- benchmark/src/main.cpp: Language not supported
- cmake/CompilerWarnings.cmake: Language not supported
- eventbus/CMakeLists.txt: Language not supported
- eventbus/include/eventbus/detail/storage_policy.hpp: Language not supported
- eventbus/include/eventbus/detail/value_traits.hpp: Language not supported
- eventbus/include/eventbus/event_bus.hpp: Language not supported
- eventbus/test/event_bus_tests.cpp: Language not supported
ptsouchlos
force-pushed
the
feature/unify-storage-types
branch
from
1e19bf1 to
786c77f
Compare
ptsouchlos
force-pushed
the
feature/unify-storage-types
branch
from
786c77f to
f886d63
Compare
jtdavis777
approved these changes
Mar 29, 2025
Contributor
jtdavis777
left a comment
jtdavis777
left a comment
There was a problem hiding this comment.
Overall this looks great. I have a few stylistic comments but the actual implementation of the bus handler looks good. I tend to prefer allowing implicit use of libraries over explicit make functions, but that's just my bias.
Owner
Author
|
@ABeltramo please take a look when you can 👍 |
Owner
Author
Awesome, thanks for the feedback. I think you made some good points. I'll see if I can address them. Thanks again! |
As suggested in code review for #41
You can now have dp::event_bus and dp::event_bus<ev1, ev2, ev3...>
Resolve build issues due to deprecated (and removed) CMake minimum version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
std::anyorstd::variantCMakePresets.jsonstd::anyandstd::variant@thejtshow Please take a look if you can. Thanks!
Resolves #33