[FEATURE] Possibility to add author.signature as image to be added above author's name in signature block.#140
Merged
ptsouchlos merged 1 commit intoptsouchlos:mainfrom Sep 27, 2025
Conversation
author's name in signature block.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds functionality to include an author's signature image in the cover letter signature block. The image appears above the author's name when the signature field is provided in the author object.
- Adds a new
signatureparameter to the function signature with typeimage - Implements conditional rendering of the signature image in the signature block
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ptsouchlos
reviewed
Sep 21, 2025
ptsouchlos
reviewed
Sep 21, 2025
Owner
ptsouchlos
left a comment
There was a problem hiding this comment.
Just one comment - lmk your thoughts and thanks for the PR!
Contributor
Author
|
Looks all good to me, I think copilot was confused by "signature" being the name of the key in the object and the name of a function at the same time. |
Owner
|
LGTM thanks again! |
ptsouchlos
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered typst and your modern-cv lib today. I found the need for adding my signature above my name in the signature block of the cover letter.
I tried adding a type check, but that broke adding the image.