Skip to content

Conversation

@ptsouchlos
Copy link
Owner

Changes

  • Added a new helper to construct contact items in the resume header
  • Added way for the end user to select what separator to use between contact items in the resume header
  • Fixed minor spacing issue with the github-link helper
  • Updated the utilities test reference image

@paulrauecker Would you mind looking at this as it's related to some of the issues I was seeing in #144.

Note that this doesn't include changes to how the contact items in the coverletter are constructed. That can be a follow up PR if this one works well.

@paulrauecker
Copy link
Contributor

Minor nitpick:

diff --git a/lib.typ b/lib.typ
index 8a19150..a09ef89 100644
--- a/lib.typ
+++ b/lib.typ
@@ -338,6 +338,7 @@
   // - link-prefix (string): The prefix to use for the link (e.g. "mailto:")
   let contact-item(item, link-prefix: "") = {
     box[
+      #set align(bottom)
       #if ("icon" in item) {
         [#item.icon]
       }

I'd add that extra align to ensure they line up at the bottom like previously.
LGTM otherwise, thanks for asking!

@ptsouchlos
Copy link
Owner Author

Minor nitpick:

diff --git a/lib.typ b/lib.typ
index 8a19150..a09ef89 100644
--- a/lib.typ
+++ b/lib.typ
@@ -338,6 +338,7 @@
   // - link-prefix (string): The prefix to use for the link (e.g. "mailto:")
   let contact-item(item, link-prefix: "") = {
     box[
+      #set align(bottom)
       #if ("icon" in item) {
         [#item.icon]
       }

I'd add that extra align to ensure they line up at the bottom like previously.
LGTM otherwise, thanks for asking!

Thanks for the feedback! Do you prefer the bottom alignment over having the icon centered (vertically) with respect to the text?

@paulrauecker
Copy link
Contributor

I prefer the bottom one simply because it forms a relatively consistent visual line (with exception of qpjy). The center alignment seems a bit chaotic to me, I'm not sure if it works with every icon correctly.

@ptsouchlos
Copy link
Owner Author

I prefer the bottom one simply because it forms a relatively consistent visual line (with exception of qpjy). The center alignment seems a bit chaotic to me, I'm not sure if it works with every icon correctly.

That's a fair point, thanks for the feedback!

Align the icons and text to "bottom" per feedback for the contact
headers items.
@ptsouchlos ptsouchlos merged commit bd46a82 into main Dec 2, 2025
3 of 4 checks passed
@ptsouchlos ptsouchlos deleted the fix/contact-item-wrapping branch December 2, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants