chore(deps): update dependency solhint to v6#931
Merged
Conversation
a4aa08c to
bb84789
Compare
1ec44b8 to
b06f6e6
Compare
b06f6e6 to
4fa2a49
Compare
4554c8f to
06af685
Compare
6044e92 to
1edb323
Compare
1693951 to
c117e85
Compare
6383f50 to
29a2086
Compare
29a2086 to
48a8faa
Compare
afc157a to
a31affd
Compare
5b11e74 to
b4a1445
Compare
c649ac1 to
cb47d68
Compare
35b308c to
e1d0ef0
Compare
e352b2e to
ad90490
Compare
a0d0316 to
9ad1d97
Compare
1f0da36 to
25cc2fb
Compare
32ae28a to
28db790
Compare
28db790 to
fbe2bf9
Compare
Owner
|
@copilot please analyze and propose a fix or improvement for this issue/PR. CI error: DetailsImportant Reference (RxDB docs for LLMs)Use the official RxDB docs here to align with architecture, plugins, storage abstractions, replication patterns, typings, and coding conventions: What to do (pick the right action based on what’s present)Bug report with no test case
Bug report with a test case already present but no fix
Regression (something used to work)
Dependency version bump required
Types/TS errors
Docs-only or README mismatch
Output requirementsPlease provide:
🚨 Author mention ruleIf your solution:
then mention the original issue/PR author at the end of your response: @ please review the proposed changes. |
Contributor
Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
fix: update .solhint.json for solhint v6 compatibility
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
5.0.5→6.0.3Release Notes
protofire/solhint (solhint)
v6.0.3Compare Source
🛠️
Fix: removed unused files, normalized schema for validation, load-rules, base-checker and validator improvements🛠️
Fix: removing console log from use-natspec rule (thanks brossetti1!!)🛠️
Fix: misc minor issues and typos. General polish and stability✨🛡️ Kudos to our contributors! 🛡️✨
v6.0.2Compare Source
🛠️
Fix: corrected use-natspec enforcement behavior on internal functions🛠️
Fix: misc minor issues and typos. General polish and stability🆕
Rule: addedfoundry-no-blockto detect usage ofblock.timestampandblock.numberin Solidity tests🆕
Rule: addedno-unused-private-functionsto prevent unused private function declarations🆕
Rule: addedno-immutable-before-declarationto enforce correct immutable declaration order🧱
Enhancement: improvements tofoundry-test-functionrule, including naming and configuration updates🧰
Infra: update GitHub Actions in CI workflows to v5 and v6. Keeps CI aligned with latest ecosystem changes🧰
Infra: bump js-yaml dependency following security recommendations🧹
Chore: stop publishing the test directory to npm packages. Reduces package size and noise🧹
Chore:foundry-test-functionsis deprecated and will be removed in v7.0.0. Please rename tofoundry-test-function-naming.WILL BE REPLACED IN v7
✨🛡️ Kudos to our contributors! 🛡️✨
v6.0.1Compare Source
🛠️
Fix:no-unused-varsfor modifiers🛠️
Fix:no-unused-importshandled for multiline @inheritdoc. Eliminates missed detections with multiline inheritance docs🛠️
Fix:func-name-mixedcaseimprovement, added snake case exception in interface (naming). Aligns interface naming edge cases🛠️
Fix: misc minor issues; docs link and typos. General polish and stability🧰
Infra: Update GitHub Actions in CI workflows. Keeps CI up to date and consistent across jobs🧰
Infra: Ignore enhancement to mimic as regular linters🧹
Chore: Remove fs-extra dependency. Simplifies deps🧹
Chore: Remove strip-ansi. Cleans unused/legacy deps🧹
Chore: Changed changelog format🧱
Enhancement: added config for no-unused-vars to validate parameters or not🧱
Validation: Improve AJV schema validation and related caching approach. More robust/faster config validation✨🛡️ Kudos to our contributors! 🛡️✨
v6.0.0Compare Source
BREAKING CHANGE
Some rules were removed from the recommended ruleset and other were promoted. See below:
Rules revision - #692
🟥 DEMOTED
payable-fallback: Outdated due to the introduction of receive(); rarely needed in modern Solidity.✅ PROMOTED
interface-starts-with-i: Promotes clarity by clearly distinguishing interfaces from contracts.gas-calldata-parameters: Encourages optimal memory usage for external functions.gas-increment-by-one: Suggests using ++i style for gas-efficient increments.gas-indexed-events: Improves event indexing for off-chain systems and reduces gas usage.gas-small-strings: Recommends cheaper encoding using bytes32 for short strings.gas-strict-inequalities: Helps avoid subtle off-by-one bugs in range conditions.gas-struct-packing: Maximizes storage efficiency by suggesting tight struct packing.duplicated-imports: Prevents redundant imports that bloat the AST and confuse code structure.import-path-check: Ensures all imported files exist and resolve correctly, avoiding runtime errors.function-max-lines: Encourages smaller, more readable and maintainable functions.constructor-syntax: Enforces modern constructor syntax for consistency and clarity.use-natspec: Promotes proper documentation with NatSpec for better audits and readability.Fixed
gas-struct-packingfalse positives - #690gas-increment-by-onebackward expression - #691Added
use-natspec: Promote the use of natspec and make several checks to enforce it - #689v5.2.0Compare Source
Fixed
imports-orderinterference withno-unused-imports- #684Added
cacheflag allowing to skip already evaluated files if no error was thrown and file did not change - #685Thanks to @smol-ninja - @PaulRBerg @lechpzn, @otc-png, @MamunC0der, @kks-code, @RidaMichofi
For making the time of proposing rules, pointing out typos, broken links, unused code, copyright, small reviews, etc. We really appreciate your contributions!
v5.1.0Compare Source
Added
no-unused-import- #648 (Thanks to @DenisGorbachev)Updated
orderingrule - #656BREAKING CHANGE
solhint:defaultruleset - #654Thanks to @fanqiaojun, @maximevtush, @MaxweLL22-22, @PixelPil0t1, @wgyt, @operagxsasha, @Hopium21, @leopardracer, @omahs, @zeevick10, @gap-editor, @Olexandr88, @jirutka
For making the time of pointing out typos, license update, broken links, unused code, copyright, small reviews, etc. We really appreciate your contributions!
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.