Skip to content

feat: Do not restart process on failure to reach Homeserver#12

Merged
86667 merged 7 commits intomasterfrom
check_homeserver_each_route
Jan 9, 2026
Merged

feat: Do not restart process on failure to reach Homeserver#12
86667 merged 7 commits intomasterfrom
check_homeserver_each_route

Conversation

@86667
Copy link
Contributor

@86667 86667 commented Jan 6, 2026

  • Check Homeserver admin password on startup
  • For SMS verification return formatted error to user when attempting to check code but homeserver is down
  • For LN verification on homeserver being down leave db item unfinalised. Sunc with phoenix is re-triggered when user queries /ln/{id} or /ln/{id}/await
  • Remove Homeserver observer
  • Remove LightningSyncer module which was causing circular dependency problems. Simplified to single LightningService which handles syncer resposibilities

@86667 86667 requested a review from SeverinAlexB January 6, 2026 17:42
@86667 86667 force-pushed the check_homeserver_each_route branch from fd57476 to d6ef470 Compare January 6, 2026 18:02
@86667 86667 force-pushed the check_homeserver_each_route branch from d6ef470 to 9d43d0c Compare January 6, 2026 19:18
@86667 86667 force-pushed the check_homeserver_each_route branch from 4a7c60c to 815c7c0 Compare January 7, 2026 10:34
@86667 86667 force-pushed the check_homeserver_each_route branch from 03c3fc9 to bed2ce0 Compare January 7, 2026 11:06
Copy link
Collaborator

@SeverinAlexB SeverinAlexB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but as you said, this doesn't solve the ln problem. Not really sure we can live without it?

@86667 86667 changed the title feat: Check Homeserver live before every verification related route feat:Do not restart process on failure to reach Homeserver Jan 7, 2026
@86667 86667 changed the title feat:Do not restart process on failure to reach Homeserver feat: Do not restart process on failure to reach Homeserver Jan 7, 2026
Copy link
Collaborator

@SeverinAlexB SeverinAlexB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct direction

Copy link
Collaborator

@SeverinAlexB SeverinAlexB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good except for my one remaining previous input.

@86667 86667 force-pushed the check_homeserver_each_route branch from 9431c83 to dfbacad Compare January 9, 2026 09:55
Copy link
Collaborator

@SeverinAlexB SeverinAlexB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@86667 86667 merged commit 76297ba into master Jan 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants