PubkyId: derive From<PublicKey>, From<Keypair>#80
Merged
ok300 merged 5 commits intopubky:mainfrom Dec 1, 2025
Merged
Conversation
tipogi
reviewed
Dec 1, 2025
Contributor
tipogi
left a comment
tipogi
left a comment
There was a problem hiding this comment.
do we need here the tests cases?
…bkyId Co-authored-by: ok300 <106775972+ok300@users.noreply.github.com>
Co-authored-by: ok300 <106775972+ok300@users.noreply.github.com>
…ations Add tests for From<PublicKey> and From<Keypair> implementations of PubkyId
Contributor
Author
|
Added tests just now. |
tipogi
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two useful
PubkyIdconversions, as discussed in pubky/pubky-core#276 (comment)