Correct status trailers to be strs in unary ASGI responses.#68
Open
willjschmitt wants to merge 1 commit intopublic:masterfrom
Open
Conversation
`pack_trailers` expects a list of `str` pairs in contrast to ASGI headers, which are `bytes` pairs. When they are passed to `pack_trailers` as `bytes` pairs, they are serialized as their bytes `repr`, which ends up as a string `"b'grpc-status'` and `"b'grpc-message'"`. It might be more desirable to unify with the ASGI spec and use bytes-pairs, but that would change the trailers pattern more in the implementation, such as deserialized counterparts. This ultimately is the smallest incremental change, which ensures trailers are written out properly and in the succesful case of unary requests, clients can decode the OK status successfully. WSGI and streaming ASGI trailer writing handled this right already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pack_trailersexpects a list ofstrpairs in contrast to ASGI headers, which arebytespairs. When they are passed topack_trailersasbytespairs, they are serialized as their bytesrepr, which ends up as a string"b'grpc-status'and"b'grpc-message'".It might be more desirable to unify with the ASGI spec and use bytes-pairs, but that would change the trailers pattern more in the implementation, such as deserialized counterparts. This ultimately is the smallest incremental change, which ensures trailers are written out properly and in the succesful case of unary requests, clients can decode the OK status successfully. WSGI and streaming ASGI trailer writing handled this right already.
Fixes #67