Handle literal paths for partials #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good! And I know it's a small change but would you be able to provide a test? |
Author
|
Hi, making a test required more changes than I'd prefer for such a small library delta. Particularly swapping app.locals -> res.locals is needed for the way express now deals with 'local' functions, they don't seem to get picked up from 'global locals' if that makes sense. |
Member
|
I think the locals "swap" you mentioned in your last comment is taken care of by e7829e8. Can you confirm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a complex views layout so I end up specifying partial views directly for mixins - this helps there, no harm otherwise.