Update aqicn.spec.js to address layer-specific test failures#670
Open
Update aqicn.spec.js to address layer-specific test failures#670
Conversation
jywarren
commented
Jun 7, 2022
| it('has circle markers in minimal mode', function() { | ||
| cy.server() | ||
| cy.route('GET', 'https://api.waqi.info/map/bounds/?latlng=31.052933985705163,-30.498046875000004,65.18303007291382,57.39257812500001&token=566331c289f0aeacd78e0b18362b4bcfa5097572', 'fixture:aqicn.json') | ||
| cy.route('GET', 'https://api.waqi.info/map/bounds/**', 'fixture:aqicn.json') |
Member
Author
There was a problem hiding this comment.
Member
Author
|
I see that for some reason it's zoomed into zoom 3, and some kind of random location. -'#lat=42.94&lon=-82.97&zoom=3&layers=Standard,aqicnLayer'
+'#lat=51.15&lon=13.45&zoom=4&layers=Standard,aqicnLayer'It doesn't look like clicking a marker and getting a popup, it doesn't pan the screen. Zoom 3 is pretty zoomed out, and -82 corrects to -52 because we can't look off the edge of the world. But otherwise looks innocuous. Not sure where 42x-82 coordinates are coming from? That's near Flint, Michigan, while the original was in Germany. Aha - ok, the default map location is set in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting some fixes to aqicn spec from #668 - reordering first, then will try ensuring we use fixture data instead of a real request on:
leaflet-environmental-layers/cypress/integration/aqicn.spec.js
Lines 26 to 43 in 26826d5