Correct remaining new RuboCop offenses

Author: mvz

app/controllers/admin/seo_controller.rb

@@ -4,6 +4,8 @@ class Admin::SeoController < Admin::BaseController
   before_action :set_setting
   before_action :set_section
 
+  VALID_SECTIONS = %w(general titles permalinks).freeze
+
   def show
     if @setting.permalink_format != "/%year%/%month%/%day%/%title%" &&
         @setting.permalink_format != "/%year%/%month%/%title%" &&
@@ -37,8 +39,6 @@ def settings_keys
     @setting.settings_keys + [:custom_permalink]
   end
 
-  VALID_SECTIONS = %w(general titles permalinks).freeze
-
   def set_section
     section = params[:section]
     @section = VALID_SECTIONS.include?(section) ? section : "general"

app/controllers/admin/settings_controller.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 class Admin::SettingsController < Admin::BaseController
+  VALID_ACTIONS = %w(index write feedback display).freeze
+
   def index
     this_blog.base_url = blog_base_url if this_blog.base_url.blank?
     load_settings
@@ -33,8 +35,6 @@ def update
 
   private
 
-  VALID_ACTIONS = %w(index write feedback display).freeze
-
   def settings_params
     @settings_params ||= params.require(:setting).permit(@setting.settings_keys)
   end

spec/features/signup_spec.rb

@@ -47,6 +47,8 @@
   scenario "Disallow account sign-up link with a blog setting" do
     Blog.first.update(allow_signup: 0)
     visit admin_dashboard_path
+
+    expect(page).to have_text "You need to sign in or sign up before continuing."
     expect(page).not_to have_link I18n.t("accounts.create_account")
 
     visit new_user_registration_path