Conversation
marcin-cebo
requested review from
jakub-grzesiowski and
jguz-pubnub
as code owners
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
marcin-cebo
force-pushed
the
mc/addStatusListener
branch
from
7080b09 to
a4a83b5
Compare
jguz-pubnub
reviewed
Jul 31, 2025
js-chat/tests/channel.test.ts
Outdated
| }) | ||
|
|
||
| test("should properly disconnect from channel and stop receiving messages with console logs", async () => { | ||
| console.log("\n=== Channel Disconnect Test ===") |
Contributor
There was a problem hiding this comment.
Do we need console.log statements here?
Contributor
Author
There was a problem hiding this comment.
No, I will remove them.
jguz-pubnub
reviewed
Jul 31, 2025
| eventCount++ | ||
| const statusValue = status.category.value | ||
| eventHistory.push(statusValue) | ||
| console.log(`[${eventCount}] Status received: ${statusValue}`) |
Contributor
There was a problem hiding this comment.
The same here in this file, why do we need console.log statements in unit tests?
Contributor
Author
There was a problem hiding this comment.
No, I will remove them.
jguz-pubnub
approved these changes
Jul 31, 2025
Contributor
|
Use a more descriptive PR title |
Contributor
Author
|
@pubnub-release-bot release kotlin as 0.15.0 |
Contributor
|
🚀 Release successfully completed 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Added new APIs: addConnectionStatusListener, reconnectSubscriptions, disconnectSubscriptions