Add limit and offset parameters to whoIsPresent methods #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
marcin-cebo
approved these changes
Jan 21, 2026
| /// Returns a collection of users currently present in any channel within the given ``ChannelGroup``. | ||
| /// | ||
| /// - Parameters: | ||
| /// - filter: Expression used to filter the results. Returns only the channels whose properties satisfy the given expression |
There was a problem hiding this comment.
filter and sort are not parameters. Don't they?
Package.swift
Outdated
| dependencies: [ | ||
| .package(url: "https://github.com/pubnub/kmp-chat", exact: "0.15.2-swift"), | ||
| .package(url: "https://github.com/pubnub/swift", exact: "9.3.2") | ||
| .package(url: "https://github.com/pubnub/kmp-chat", exact: "0.16.1-swift"), |
There was a problem hiding this comment.
I don't see changes in tests. What about modifying tests so that they cover e.g. limit param?
Contributor
Author
There was a problem hiding this comment.
I'll add them 👍
Contributor
Author
|
@pubnub-release-bot release as 0.34.0 |
jguz-pubnub
force-pushed
the
fix/here-now
branch
from
0c47d57 to
8ae928c
Compare
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(presence): add limit and offset parameters to whoIsPresent methods