Bugfix: Implicit label kotlin deps error out#56
Open
trevorsummerssmith wants to merge 1 commit intopubref:masterfrom
Open
Bugfix: Implicit label kotlin deps error out#56trevorsummerssmith wants to merge 1 commit intopubref:masterfrom
trevorsummerssmith wants to merge 1 commit intopubref:masterfrom
Conversation
If one specifies a non-absolute kotlin dependency that ends in the package name, eg '/foo' the code would suffix the _package name_ with "_kt", resulting in an error. The correct behavior is to suffix the target name. This commit fixes this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one specifies a non-absolute kotlin dependency that ends in the
package name, eg 'foo' the code would suffix the package name
with "_kt", resulting in an error. The correct behavior is to suffix
the target name. This commit fixes this issue.