Draft
Conversation
hectorcorrea
commented
Mar 19, 2026
| // const tab = document.getElementById('tab-nav'); | ||
| styleTab("#dash-projects", project); | ||
| styleTab("#dash-admin", admin); | ||
| styleTab("#dash-requests", requests); |
Member
Author
There was a problem hiding this comment.
Made the original code into a function styleTab() and call it for each tab.
hectorcorrea
commented
Mar 19, 2026
| }); | ||
| setupTab("#dash-projects", "/dash_project", "project"); | ||
| setupTab("#dash-admin", "/dash_admin", "admin"); | ||
| setupTab("#dash-requests", "/dash_requests", "requests"); |
Member
Author
There was a problem hiding this comment.
Ditto, made the original code into a function setupTab() and call it for each tab.
hectorcorrea
commented
Mar 19, 2026
| globusAccessPopover.hidePopover(); | ||
| triggerMailer(projectId); | ||
| }); | ||
| if (switchGlobusPopover !== null) { |
Member
Author
There was a problem hiding this comment.
This is technically not part of this GitHub ticket, but added an if statement to prevent this code from executing when the switchGlobusPopover is not on the page that way we don't get an error in JavaScript console every time it executes in pages that don't need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the "Requests" button and instead display the requests directly in the Dashboard under a new tab named "Requests"
Closes #2470