Use index instead of shit to avoid changing input

[ruifortes]

No description provided.

[dominictarr]

this is a breaking change because it reverses the order that the array is added to the stream.
what is the goal here? is it performance or purity?

[ruifortes]

Sorry about the order.
In my case the goal was to mutate the source.
Nevertheless should the source preferentially kept intact?

[dominictarr]

sorry I don't understand. Can you explain what you are using this for and why you need this change?

[ruifortes]

ok, its not the ideal use of pull-streams but I was iterating a large json object.
For the result list I wanted some filtered and unique results but meanwhile I also wanted to fix some issues in the original json.
So, besides geting the filtered results I also wanted to mutate de source.
Granted it's not the ideal scenario for pull-streams I guess that keeping the input untouch should be prefered to changing it. Unless that's intentional of course.
Is this a bad practice?

[dominictarr]

Well, if you are gonna do it like that, you should make a pull-stream module that is about that, with tests for that usecase... pull-flatmap is intended to be a functional programming pattern, so it does not approve of mutations like this.

[ruifortes]

But right now pull-flatmap DOES mutates the input. It zeroes the input arrays.
Does it need to do that to follow the functional programming pattern?
"map" followed by "flatten" doesn't

[dominictarr]

I mean, the part that is ment to be functional is the function you pass to flatmap.
how flatmap works internally is it's own business, and you probably shouldn't be holding a reference to that array after you return it.
if you did want to mutate the array though... it seems to me my way might work better because at least you can inspect the array and see what hasn't been emitted from the stream yet, on the other hand, if it used an index you wouldn't know if you were adding an item that was still gonna be in the stream or not.

Anyway, I'm not gonna merge this because it's a unnecessary breaking change.