Skip to content

fix: remove unnecessary code and dependency#18

Open
joepie91 wants to merge 1 commit intopull-stream:masterfrom
joepie91:master
Open

fix: remove unnecessary code and dependency#18
joepie91 wants to merge 1 commit intopull-stream:masterfrom
joepie91:master

Conversation

@joepie91
Copy link
Copy Markdown

Seems like some cruft left over from an older revision of the code.

  • pull-stream as a dependency is now only used in tests, so moved to devDependencies
  • draining variable is unused
  • first function is unused

Copy link
Copy Markdown

@huahang huahang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants