Skip to content

fix: remove unnecessary code and dependency #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove unnecessary code and dependency #18

wants to merge 1 commit into from

Conversation

joepie91
Copy link

Seems like some cruft left over from an older revision of the code.

  • pull-stream as a dependency is now only used in tests, so moved to devDependencies
  • draining variable is unused
  • first function is unused

huahang
huahang approved these changes Dec 1, 2020
View reviewed changes
Copy link

@huahang huahang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@huahang huahang huahang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joepie91 @huahang