[NetworkDeployer] Node Mangling to avoid duplication #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeratec
reviewed
Jun 10, 2025
Member
|
Also, please do not forget to adjust the CHANGELOG ;) (This is also a note to me) |
Member
|
@viv-eth Any plans to work on this in the next 2 weeks? Alternatively, I can offer to take it over, but will most likely include it in the next release. |
Xeratec
modified the milestones:
Release 0.2.0,
Release xxx,
Release 0.3.0,
Release 0.2.1
viv-eth
force-pushed
the
vivianep/mangleNodes
branch
from
6a33901 to
fffe9c7
Compare
Xeratec
requested changes
Jul 30, 2025
Member
Xeratec
left a comment
Xeratec
left a comment
There was a problem hiding this comment.
Please rebase the PR and make sure to extend the CHANGELOG in the right place. Otherwise, the changes are good. Thanks a lot!
viv-eth
force-pushed
the
vivianep/mangleNodes
branch
from
fffe9c7 to
e0828c4
Compare
Contributor
Author
Xeratec
force-pushed
the
vivianep/mangleNodes
branch
from
e0828c4 to
4e903b4
Compare
Xeratec
approved these changes
Aug 19, 2025
Member
Xeratec
left a comment
Xeratec
left a comment
There was a problem hiding this comment.
The changes were added under v0.2.0 and not under v0.2.1. I did change it and merge once the tests succeed.
diaconuccalin
pushed a commit
to Aldrago98/Deeploy
that referenced
this pull request
Oct 17, 2025
* [NetworkDeployer] Mangle these n...odes * [DeeployTypes] Only mangle on duplicates * Update changelog --------- Co-authored-by: viv-eth <[email protected]>
diaconuccalin
pushed a commit
to diaconuccalin/Deeploy
that referenced
this pull request
Oct 27, 2025
* [NetworkDeployer] Mangle these n...odes * [DeeployTypes] Only mangle on duplicates * Update changelog --------- Co-authored-by: viv-eth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a node‐name mangling pass in the Deploy front end to ensure every node in the graph has a unique, non‐empty name. Previously, nodes generated by
GraphSurgeonwithout an explicit name would collide, causing later layers to overwrite earlier layer bindings. With this change, each node is automatically assigned a name based on its operation and an incrementing counter, guaranteeing uniqueness and preserving all layer bindings.Added
DeployTypes._mangleNodeNames(self)helper that:"{op_name}_{idx}", using the op’s class or string reprself._mangleNodeNames()infrontEnd()immediately after tensor‐name manglingChanged
DeployTypes.frontEnd()to call_mangleNodeNames()before renaming graph inputs/outputsFixed
"", so no two nodes share the same namePR Merge Checklist
develcommit and pointing todevel.CHANGELOG.mdfile has been updated.