Skip to content

axi_to_detailed_mem: Avoid spurious write responses with HideStrb #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micprog merged 2 commits into from
Jul 24, 2025
Merged

axi_to_detailed_mem: Avoid spurious write responses with HideStrb #383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7edfaed
axi_to_detailed_mem: Avoid spurious write responses with HideStrb
MaxWipfli Jul 10, 2025
724929c
Merge branch 'master' into axi_to_mem_dead_resp
micprog Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/axi_to_detailed_mem.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,23 +908,28 @@ module mem_stream_to_banks_detailed #(
assign mem_req_ready = (&req_ready) & (&resp_ready) & !dead_write_fifo_full;

if (HideStrb) begin : gen_dead_write_fifo
logic dead_write_fifo_empty;
logic [NumBanks-1:0] dead_write_fifo_out_data;
fifo_v3 #(
.FALL_THROUGH ( 1'b0 ),
.DEPTH ( MaxTrans+1 ),
.DATA_WIDTH ( NumBanks )
) i_dead_write_fifo (
.clk_i,
.rst_ni,
.flush_i ( 1'b0 ),
.testmode_i ( 1'b0 ),
.full_o ( dead_write_fifo_full ),
.empty_o (),
.usage_o (),
.data_i ( bank_we_o & zero_strobe ),
.push_i ( mem_req_valid & mem_req_ready ),
.data_o ( dead_response ),
.pop_i ( rvalid_o & rready_i )
.flush_i ( 1'b0 ),
.testmode_i ( 1'b0 ),
.full_o ( dead_write_fifo_full ),
.empty_o ( dead_write_fifo_empty ),
.usage_o ( ),
.data_i ( bank_we_o & zero_strobe ),
.push_i ( mem_req_valid & mem_req_ready ),
.data_o ( dead_write_fifo_out_data ),
.pop_i ( rvalid_o & rready_i )
);
// We only actually have a dead response if the FIFO is not empty. Otherwise, we could signal
// rvalid_o based on stale data in the FIFO.
assign dead_response = dead_write_fifo_empty ? '0 : dead_write_fifo_out_data;
end else begin : gen_no_dead_write_fifo
assign dead_response = '0;
assign dead_write_fifo_full = 1'b0;
Expand Down