Skip to content

treewide: Fix various lint issues #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niwis wants to merge 3 commits into
base: master
Choose a base branch
from
+12 −5
Open

treewide: Fix various lint issues #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf67b6a
axi_lite_lfsr: Fix inferred latch
niwis Mar 25, 2026
b366a4c
axi_id_serialize: Fix implicit int to bool conversion
niwis Mar 27, 2026
9d4f4e0
various: Add missing id_queue ports
niwis Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/axi_burst_splitter_gran.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,9 @@ module axi_burst_splitter_gran_counters #(
.oup_req_i ( cnt_req_i ),
.oup_data_o ( cnt_r_idx ),
.oup_data_valid_o ( idq_oup_valid ),
.oup_gnt_o ( idq_oup_gnt )
.oup_gnt_o ( idq_oup_gnt ),
.full_o (/* keep open */),
.empty_o (/* keep open */)
);
assign idq_inp_req = alloc_req & alloc_gnt;
assign alloc_gnt = idq_inp_gnt & |(cnt_free);
Expand Down
4 changes: 3 additions & 1 deletion src/axi_burst_unwrap.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,9 @@ module axi_burst_counters #(
.oup_req_i ( cnt_req_i ),
.oup_data_o ( cnt_r_idx ),
.oup_data_valid_o ( idq_oup_valid ),
.oup_gnt_o ( idq_oup_gnt )
.oup_gnt_o ( idq_oup_gnt ),
.full_o (/* keep open */),
.empty_o (/* keep open */)
);
assign idq_inp_req = alloc_req_i & alloc_gnt_o;
assign alloc_gnt_o = idq_inp_gnt & |(cnt_free);
Expand Down
4 changes: 3 additions & 1 deletion src/axi_dw_downsizer.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,9 @@ module axi_dw_downsizer #(
.exists_mask_i ('0 ),
.exists_req_i ('0 ),
.exists_o (/* Unused */ ),
.exists_gnt_o (/* Unused */ )
.exists_gnt_o (/* Unused */ ),
.full_o (/* Unused */ ),
.empty_o (/* Unused */ )
);

for (genvar t = 0; unsigned'(t) < AxiMaxReads; t++) begin: gen_read_downsizer
Expand Down
2 changes: 1 addition & 1 deletion src/axi_id_serialize.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ module axi_id_serialize #(
else $fatal(1, "Not enought Id width on MST port to map all ID's.");
assert(AxiSlvPortIdWidth > 32'd0)
else $fatal(1, "Parameter AxiSlvPortIdWidth has to be larger than 0!");
assert(AxiMstPortIdWidth)
assert(AxiMstPortIdWidth > 32'd0)
else $fatal(1, "Parameter AxiMstPortIdWidth has to be larger than 0!");
assert(AxiMstPortIdWidth <= AxiSlvPortIdWidth)
else $fatal(1, "Downsize implies that AxiMstPortIdWidth <= AxiSlvPortIdWidth!");
Expand Down
3 changes: 2 additions & 1 deletion src/axi_lite_lfsr.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ module axi_opt_lfsr #(

always_comb begin : gen_register

xnor_feedback = reg_q[XnorFeedback[MaxNumTabs-1]-1];

// get the parameters
case (Width)
'd8 : XnorFeedback = { 'd8, 'd6, 'd5, 'd4 };
Expand Down Expand Up @@ -203,7 +205,6 @@ module axi_opt_lfsr #(
reg_d[Width-1] = ser_data_i;
// LFSR mode
end else begin
xnor_feedback = reg_q[XnorFeedback[MaxNumTabs-1]-1];
for (int unsigned t = 0; t < MaxNumTabs - 1; t++) begin : gen_feedback_path
xnor_feedback = xnor_feedback;
if (XnorFeedback[t] != 0) begin
Expand Down
Loading