Update signing key fields to include a version prefix#4382
Conversation
pulp_rpm/app/migrations/0071_remove_max_length_from_fingerprint_fields.py
Outdated
Show resolved
Hide resolved
|
|
||
| original_package_sha256 = models.TextField(max_length=64) | ||
| package_signing_fingerprint = models.TextField(max_length=40) | ||
| package_signing_fingerprint = models.TextField() |
There was a problem hiding this comment.
@ggainey adding a prefix here would be an API change, should we just add a new field to store type info?
There was a problem hiding this comment.
I kind of had assumed that we wouldn't want to add type info to this field. I'm assuming if we added it the user would have to supply that info? Is there a case where Pulp would need the type info?
There was a problem hiding this comment.
By type info I just mean the prefix.
daviddavis
force-pushed
the
update-fingerprint-fields
branch
from
707a02a to
4b024e5
Compare
daviddavis
changed the title
|
@daviddavis unless github is glitching again it looks like you need to rebase against main |
daviddavis
force-pushed
the
update-fingerprint-fields
branch
from
4b024e5 to
f3069ab
Compare
daviddavis
force-pushed
the
update-fingerprint-fields
branch
from
f3069ab to
34ae385
Compare
github-actions
bot
added
multi-commit
daviddavis
force-pushed
the
update-fingerprint-fields
branch
3 times, most recently
from
296d1de to
701c4dc
Compare
github-actions
bot
removed
multi-commit
|
That race condition in the tests is getting really tedious (not your fault) |
|
@daviddavis Otherwise, this looks good - I assume you're planning to move copy the fingerprint parsing stuff over to pulpcore eventually so that plugins can share? |
daviddavis
force-pushed
the
update-fingerprint-fields
branch
2 times, most recently
from
fadf506 to
e4395ca
Compare
|
Here's a pulpcore PR: pulp/pulpcore#7510 |
|
Pulpcore with the new field should be released now, so you can just depend on pulpcore 3.106 and import it. |
daviddavis
force-pushed
the
update-fingerprint-fields
branch
3 times, most recently
from
9ecdf69 to
a12f9c0
Compare
Assisted By: Claude Opus 4.6
daviddavis
force-pushed
the
update-fingerprint-fields
branch
from
a12f9c0 to
026037b
Compare
2 participants
No description provided.