Conversation
e2bf6c7 to
ce25df5
Compare
1c5e4f8 to
a2bff51
Compare
a2bff51 to
8aab825
Compare
mdellweg
reviewed
Dec 13, 2024
Comment on lines
-337
to
-357
| def test_emmiting_unblocked_task_telemetry(dispatch_task, pulpcore_bindings, pulp_settings): | ||
| # Checking online workers ready to get a task | ||
| workers_online = pulpcore_bindings.WorkersApi.list(online="true").count | ||
|
|
||
| # We need to generate long running tasks to block the workers from executing other tasks | ||
| resident_task_hrefs = [ | ||
| dispatch_task("pulpcore.app.tasks.test.sleep", args=(30,)) | ||
| for worker in range(workers_online) | ||
| ] | ||
|
|
||
| # Then we dispatch a quick unblockable task just to keep it waiting in the queue | ||
| task_href = dispatch_task("pulpcore.app.tasks.test.sleep", args=(0,)) | ||
|
|
||
| task = pulpcore_bindings.TasksApi.read(task_href) | ||
| assert task.state == "waiting" | ||
|
|
||
| [ | ||
| pulpcore_bindings.TasksApi.tasks_cancel(task_href, {"state": "canceled"}) | ||
| for task_href in resident_task_hrefs | ||
| ] | ||
|
|
Member
There was a problem hiding this comment.
Reference for future me: Just in case you are wondering why this test get's removed. I has had no guts anymore since we stopped testing for the actual telemetry to arrive somewhere. This is just an empty shell eating CPU cycles.
8aab825 to
1bc3611
Compare
Member
|
s3 tests are failing for (damn it pip!): after and when installing the bindings over the application packages. |
5fd49b4 to
1b9cf36
Compare
1b9cf36 to
4af672e
Compare
Member
|
So let's see if adjusting the dateutil requirements in our bindings builds solve the last issues. |
4af672e to
3c0f335
Compare
db4272d to
4c27f78
Compare
473c421 to
c291528
Compare
c291528 to
b448501
Compare
ggainey
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action