[PULP-659] Remove legacy django storages#6838
Merged
Conversation
a160888 to
2c53bc4
Compare
f3a6e73 to
542b73a
Compare
8b3ac9b to
45275dd
Compare
499533c to
9415d79
Compare
9415d79 to
316057e
Compare
mdellweg
reviewed
Aug 11, 2025
Comment on lines
+138
to
+152
| {%- if test_storages_compat_layer is not defined -%} | ||
| {%- if s3_test | default(false) -%}{{ s3_settings(legacy=True) }}{%- endif -%} | ||
| {%- if azure_test | default(false) -%}{{ azure_settings(legacy=True) }}{%- endif -%} | ||
| {%- if gcp_test | default(false) -%}{{ gcp_settings(legacy=True) }}{%- endif -%} | ||
| {%- else -%} | ||
| {%- if test_storages_compat_layer is true -%} | ||
| {%- if s3_test | default(false) -%}{{ s3_settings(legacy=False) }}{%- endif -%} | ||
| {%- if azure_test | default(false) -%}{{ azure_settings(legacy=True) }}{%- endif -%} | ||
| {%- if gcp_test | default(false) -%}{{ gcp_settings(legacy=True) }}{%- endif -%} | ||
| {%- elif test_storages_compat_layer is false -%} | ||
| {%- if s3_test | default(false) -%}{{ s3_settings(legacy=False) }}{%- endif -%} | ||
| {%- if azure_test | default(false) -%}{{ azure_settings(legacy=False) }}{%- endif -%} | ||
| {%- if gcp_test | default(false) -%}{{ gcp_settings(legacy=False) }}{%- endif -%} | ||
| {%- endif -%} | ||
| {%- endif -%} |
Member
There was a problem hiding this comment.
Suggested change
| {%- if test_storages_compat_layer is not defined -%} | |
| {%- if s3_test | default(false) -%}{{ s3_settings(legacy=True) }}{%- endif -%} | |
| {%- if azure_test | default(false) -%}{{ azure_settings(legacy=True) }}{%- endif -%} | |
| {%- if gcp_test | default(false) -%}{{ gcp_settings(legacy=True) }}{%- endif -%} | |
| {%- else -%} | |
| {%- if test_storages_compat_layer is true -%} | |
| {%- if s3_test | default(false) -%}{{ s3_settings(legacy=False) }}{%- endif -%} | |
| {%- if azure_test | default(false) -%}{{ azure_settings(legacy=True) }}{%- endif -%} | |
| {%- if gcp_test | default(false) -%}{{ gcp_settings(legacy=True) }}{%- endif -%} | |
| {%- elif test_storages_compat_layer is false -%} | |
| {%- if s3_test | default(false) -%}{{ s3_settings(legacy=False) }}{%- endif -%} | |
| {%- if azure_test | default(false) -%}{{ azure_settings(legacy=False) }}{%- endif -%} | |
| {%- if gcp_test | default(false) -%}{{ gcp_settings(legacy=False) }}{%- endif -%} | |
| {%- endif -%} | |
| {%- endif -%} | |
| {%- if s3_test | default(false) -%}{{ s3_settings(legacy=test_storages_compat_layer is not defined) }}{%- endif -%} | |
| {%- if azure_test | default(false) -%}{{ azure_settings(legacy=test_storages_compat_layer | default(True)) }}{%- endif -%} | |
| {%- if gcp_test | default(false) -%}{{ gcp_settings(legacy=test_storages_compat_layer | default(True)) }}{%- endif -%} |
mdellweg
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does:
For Plugins
test_storages_compat_layer: Falseintemplate_config.ymlso it only renders the newer storage settings for every storage case (s3 and azure).>=3.70. If a pulpcore<3.70is used, the CI installation can break (most likely on the lowerbound scenario), as it doest support the newer storage form.