Skip to content

Fix misnamed variable in rebuild command #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeeDeeG merged 2 commits into from
Nov 5, 2025
Merged

Fix misnamed variable in rebuild command #155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0c0cb7
Fix misnamed variable in `rebuild` command
savetheclocktower Nov 3, 2025
02b0c54
Update src/rebuild.js
savetheclocktower Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/rebuild.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ All the modules will be rebuilt if no module names are specified.\
return new Promise((resolve, reject) =>
void this.fork(this.atomNpmPath, rebuildArgs, {env}, (code, stderr) => {
if (code !== 0) {
reject(stderr ?? '');
reject(stderr ?? `Unknown error while invoking npm: code ${code}`);
return;
}

Expand All @@ -72,7 +72,7 @@ All the modules will be rebuilt if no module names are specified.\
this.logSuccess();
} catch (error) {
this.logFailure();
return stderr; //errors as return values atm
return error; // errors as return values atm
}
}
}