Skip to content

Commit d54e025

Browse files
committed
fix: remove lint mode from buildifier config to allow CI override
- Remove lint_mode from buildifier rule to allow command line control - Remove mode and lint from .buildifier.json to avoid conflicts - CI now properly checks only formatting with --lint=off - Lint warnings shown separately as informational only
1 parent 222c508 commit d54e025

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

.buildifier.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
{
22
"type": "auto",
3-
"mode": "fix",
4-
"lint": "warn",
53
"warningsList": [
64
"load",
75
"load-on-top",

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ jobs:
2626
- name: Check Buildifier Formatting
2727
run: |
2828
echo "Checking Bazel file formatting..."
29-
# Check only formatting, not lint warnings (for now)
30-
bazel run //:buildifier -- --mode=check -r .
29+
# Check only formatting, not lint warnings
30+
bazel run //:buildifier -- --lint=off --mode=check -r .
3131
3232
- name: Show Lint Warnings (Informational)
3333
run: |

BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ exports_files([
1515
buildifier(
1616
name = "buildifier",
1717
diff_command = "diff -u",
18-
lint_mode = "warn",
1918
mode = "fix",
2019
)
2120

0 commit comments

Comments
 (0)