fix: add bitflags module to embedded wit_bindgen runtime #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bitflags module to the embedded runtime in rust_wasm_component_bindgen.bzl to support WASI filesystem interfaces that generate bitflags for DescriptorFlags, PathFlags, and OpenFlags. Changes: - Add pub mod bitflags with pub(crate) use bitflags in both guest and native-guest wrappers - Add bitflags dependency to both bindings libraries - Add bitflags crate to tools/checksum_updater Cargo.toml The bitflags macro is now accessible as crate::wit_bindgen::rt::bitflags::bitflags! as expected by generated code. Tested with: - //examples/basic:hello_component_bindings_host - //tools/checksum_updater_wasm:checksum_updater_wasm_component (uses wasi:filesystem/types)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds bitflags module to the embedded wit_bindgen runtime to support WASI filesystem interfaces.
Changes
pub mod bitflagswithpub(crate) use bitflags;to both guest and native-guest wrapper modesbindings_lib_hostandbindings_lib_wasm_base)Technical Details
The bitflags macro is now accessible as
crate::wit_bindgen::rt::bitflags::bitflags!as expected by generated code from wit-bindgen when using WASI filesystem interfaces.WASI filesystem types like
wasi:filesystem/typesgenerate bitflags for:Without this fix, builds would fail with "could not find bitflags in rt" errors.
Testing
✅ Tested with:
//examples/basic:hello_component_bindings_host- builds successfully//tools/checksum_updater_wasm:checksum_updater_wasm_component- builds successfully (uses wasi:filesystem/[email protected])Both targets compile without bitflags-related errors.