fix(wit): correct wasi:[email protected] dependencies #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avrabe
force-pushed
the
fix/wasi-http-0.2.3-deps
branch
2 times, most recently
from
bf10349 to
12fbca4
Compare
Fix incorrect WASI 0.2.3 WIT dependency definitions: - wasi:[email protected]: add missing deps on cli and random, fix interfaces - wasi:[email protected]: add missing dep on wasi:io (monotonic-clock uses poll) - wasi:[email protected]: add missing dep on wasi:clocks Add WASI 0.2.8 (latest stable) with correct dependency chains: - wasi:[email protected] (base, no deps) - wasi:[email protected] (deps: io) - wasi:[email protected] (deps: io) - wasi:[email protected] (deps: io, clocks) - wasi:[email protected] (deps: io, clocks) - wasi:[email protected] (no deps) - wasi:[email protected] (deps: io, clocks, cli, random) Register new 0.2.8 repositories in MODULE.bazel use_repo().
avrabe
force-pushed
the
fix/wasi-http-0.2.3-deps
branch
from
12fbca4 to
9186daf
Compare
macos-13 runners are being deprecated by GitHub Actions. See actions/runner-images#13046
Add WASI 0.2.6 WIT interfaces with correct dependency chains: - wasi:[email protected] (base, no deps) - wasi:[email protected] (deps: io) - wasi:[email protected] (deps: io) - wasi:[email protected] (deps: io, clocks) - wasi:[email protected] (deps: io, clocks) - wasi:[email protected] (no deps) - wasi:[email protected] (deps: io, clocks, cli, random) This version matches the WASI interfaces used by wasi-sdk 29 through wasm-component-ld 0.5.19 and wasmtime v38.0.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WASI Version → SDK Mapping
WASI 0.2.3 Fixes
wasi:[email protected]: Added missing deps on@wasi_cli//:cliand@wasi_random//:random, fixed interfaces listwasi:[email protected]: Added missing dep on@wasi_io//:streams(monotonic-clock uses wasi:io/[email protected])wasi:[email protected]: Added missing dep on@wasi_clocks//:clocksWASI 0.2.6 Additions (for wasi-sdk 29)
All WASI 0.2.6 interfaces with correct dependency chains:
wasi:[email protected](base, no deps)wasi:[email protected](deps: io)wasi:[email protected](deps: io)wasi:[email protected](deps: io, clocks)wasi:[email protected](deps: io, clocks)wasi:[email protected](no deps)wasi:[email protected](deps: io, clocks, cli, random)WASI 0.2.8 Additions (latest stable)
All WASI 0.2.8 interfaces with correct dependency chains:
wasi:[email protected](base, no deps)wasi:[email protected](deps: io)wasi:[email protected](deps: io)wasi:[email protected](deps: io, clocks)wasi:[email protected](deps: io, clocks)wasi:[email protected](no deps)wasi:[email protected](deps: io, clocks, cli, random)Test plan
@wasi_http//:http(0.2.3)@wasi_clocks//:clocks(0.2.3)@wasi_sockets//:sockets(0.2.3)@wasi_*_v026//)@wasi_*_v028//)