refactor: remove deprecated tools/file_operations_component #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rust-based file_operations_component has been superseded by: - tools/file_ops (Go implementation) - current production path - tools/file_ops_external (WASM component with AOT) - preferred path Changes: - Delete tools/file_operations_component directory (Rust CLI) - Move WIT interface definition to tools/file_ops/wit/ - Update all toolchain references to use //tools/file_ops:wit_files - Update dual_implementation tests to use Go implementation - Remove dependabot entry for deleted Cargo.toml This removes ~600 lines of unused Rust code and simplifies the file operations toolchain architecture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tools/file_operations_componentdirectorytools/file_ops/wit/Context
The Rust
file_operations_componenthas been superseded by:tools/file_ops- Go implementation (current production path)tools/file_ops_external- WASM component with AOT compilation (preferred path)The Rust implementation was not actually used by the production toolchain. Only the WIT interface file was referenced, which has been moved to
tools/file_ops/wit/.This removes ~600 lines of unused Rust code and simplifies the file operations toolchain architecture.
Test plan
bazel build //tools/file_ops:file_ops //tools/file_ops:wit_filessucceedsbazel build //test/dual_implementation:allsucceedsRelated
Closes PR #214 (wit-bindgen update for file_operations_component) as obsolete