fix(cpp): use reactor exec-model for library components #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpp_component was incorrectly producing command-mode components that export wasi:cli/run and expect a main() function. This caused: - undefined_weak:main warnings during compilation - Incorrect exports that prevent component composition Add explicit -mexec-model flags to differentiate: - cpp_component: -mexec-model=reactor (library, exports _initialize) - cpp_wasm_binary: -mexec-model=command (CLI, exports _start) Also add exec_model to WasmComponentInfo metadata for introspection. Fixes #302 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
avrabe
force-pushed
the
fix/302-cpp-component-reactor-mode
branch
from
c242167 to
1bf8af8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-mexec-model=reactortocpp_componentcompilation (library components)-mexec-model=commandtocpp_wasm_binarycompilation (CLI executables)exec_modelto WasmComponentInfo metadata for introspectionProblem
cpp_componentwas incorrectly producing command-mode components that:wasi:cli/[email protected](CLI interface, not library)main()function causingundefined_weak:mainwarningsRoot Cause
Both
cpp_componentandcpp_wasm_binaryused identical clang invocations without specifying-mexec-model. WASI SDK defaults to command mode.Solution
cpp_componentreactor_initializecpp_wasm_binarycommand_start(main)Test plan
//examples/cpp_component/simple_calculator:simple_calculatorwasm-tools component wit- nowasi:cli/run//test/cpp_binary:hello_cppFixes #302