Skip to content

Conversation

@pose
Copy link
Contributor

@pose pose commented Oct 23, 2025

Part of https://github.com/pulumi/home/issues/4348

Backport the APN 1.1 marketplace change to v6: #5910

@pose pose changed the title Appending Pulumi APN 1.1 marketplace id to User Agent request header. Appending Pulumi APN 1.1 marketplace id to User Agent request header Oct 23, 2025
@pose pose changed the base branch from master to v6-security-patch October 23, 2025 10:16
@pose pose marked this pull request as ready for review October 23, 2025 10:20
@pose pose requested a review from corymhall October 23, 2025 10:22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be changing, but it looks like it's just the tests so maybe it's fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the issue is that somehow the diff moved the functions around. Not sure why the diff generation is not stable. I didn't modify any of these files as part of my change.

Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we can merge this as-is, we do need to actually also update the workflow changes that pertain to version gating here.

We can merge as-is, but we wouldn't be able to tag the release safely.

pulumi/ci-mgmt#1808 will only pertain to current default going forwards.

@guineveresaenger guineveresaenger requested a review from a team November 5, 2025 19:13
@guineveresaenger
Copy link
Contributor

update: I've pushed the two tweaks to prevent latest from causing automatic docs builds and outdated YAML downloads.

Requested a review from the rest of the team.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.72%. Comparing base (520b551) to head (2c79a82).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           v6-security-patch    #5920       +/-   ##
======================================================
- Coverage              24.45%   12.72%   -11.73%     
======================================================
  Files                    367      366        -1     
  Lines                 148274    81097    -67177     
======================================================
- Hits                   36253    10319    -25934     
+ Misses                111922    70759    -41163     
+ Partials                  99       19       -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pose
Copy link
Contributor Author

pose commented Nov 6, 2025

Re-running failed CI jobs as they seem unrelated to the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants