Open
Conversation
da34917 to
ec7a460
Compare
rosieks
reviewed
Jun 13, 2025
| public interface IPolicyManager | ||
| { | ||
| /// <summary> | ||
| /// ReportViolation reports a policy violation with the given message and optional URN (it can be left null or empty). |
Contributor
There was a problem hiding this comment.
ReportViolation is redundant. There's no reason to write method name in summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not complete, but it's enough to get the first two conformance tests we wrote for policy passing.
This is pretty much a copy of the Go SDK (which heavily copied from the python and nodejs SDKs), plus taking some ideas from the C# provider SDK.
A few things worth calling out.
WaitDelayto the run plugin code. Seemed the dotnet run of the analyzer plugin could leave stdio pipes open even though it had terminated. WithoutWaitDelayrun plugin would block forever oncmd.Wait().