Skip to content

Fix lint issues#4132

Merged
blampe merged 9 commits intomasterfrom
blampe/lint-fixes
Feb 9, 2026
Merged

Fix lint issues#4132
blampe merged 9 commits intomasterfrom
blampe/lint-fixes

Conversation

@blampe
Copy link
Contributor

@blampe blampe commented Feb 5, 2026

Lint fixes in preparation of pulumi/ci-mgmt#2024.

The bulk of this is long-line-length fixes and dot-import fixes.

@blampe blampe requested review from a team and guineveresaenger February 5, 2026 22:13
@blampe blampe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look reasonable. Any chance you can point me to a successful lint run using the planned linting enablement?

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 52.18447% with 197 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.51%. Comparing base (a1cf1b3) to head (a71e7ce).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/provider/helm_release.go 0.00% 49 Missing ⚠️
provider/pkg/provider/provider.go 16.94% 47 Missing and 2 partials ⚠️
provider/pkg/helm/tool.go 6.25% 15 Missing ⚠️
provider/pkg/await/await.go 79.41% 14 Missing ⚠️
provider/pkg/provider/provider_parameterize.go 0.00% 11 Missing ⚠️
provider/pkg/provider/yaml/v2/yaml.go 44.44% 10 Missing ⚠️
provider/pkg/gen/schema.go 0.00% 9 Missing ⚠️
provider/pkg/await/ingress.go 55.55% 8 Missing ⚠️
provider/pkg/gen/examples/upstream/generate.go 0.00% 7 Missing ⚠️
provider/pkg/provider/invoke_helm_template.go 0.00% 6 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4132      +/-   ##
==========================================
+ Coverage   44.47%   44.51%   +0.04%     
==========================================
  Files          86       86              
  Lines        9920    10142     +222     
==========================================
+ Hits         4412     4515     +103     
- Misses       5106     5226     +120     
+ Partials      402      401       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blampe blampe merged commit 0fb51f6 into master Feb 9, 2026
21 checks passed
@blampe blampe deleted the blampe/lint-fixes branch February 9, 2026 23:05
github-merge-queue bot pushed a commit to pulumi/ci-mgmt that referenced this pull request Feb 10, 2026
Followup to #2018.

* Ship a consistent lint workflow to all providers.
* Ship a consistent `.golangci.yml` to all providers.
* Completely delegate lint in CI to `make lint`.
* Rename `make lint_provider` to `make lint` for consistency across all
providers.

Rolling this out will require resolving some lint errors first. I'll do
a dry run across all providers to see how bad it is first.

- [x] pulumi/pulumi-terraform#948
(pulumi/pulumi-terraform#953)
- [x] pulumi/pulumi-terraform-module#716
- [x] pulumi/pulumi-kubernetes#4124
(pulumi/pulumi-kubernetes#4132)
- [x] pulumi/pulumi-kubernetes-ingress-nginx#517
(pulumi/pulumi-kubernetes-ingress-nginx#521)
- [x] pulumi/pulumi-kubernetes-coredns#613
(pulumi/pulumi-kubernetes-coredns#621)
- [x] pulumi/pulumi-docker-build#752
(pulumi/pulumi-docker-build#755)
- [ ] pulumi/pulumi-kubernetes-cert-manager#839
- [x] pulumi/pulumi-command#1131
(pulumi/pulumi-command#1133)
- [x] pulumi/pulumi-provider-boilerplate#1097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/no-changelog-required This issue doesn't require a CHANGELOG update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants