-
Notifications
You must be signed in to change notification settings - Fork 50
Refactor Set and List Diff tests to use generic utilities #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Jan 16, 2025
f800d2d to
d007cd3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
+ Coverage 67.22% 67.48% +0.26%
==========================================
Files 325 325
Lines 41633 41633
==========================================
+ Hits 27986 28097 +111
+ Misses 12072 11957 -115
- Partials 1575 1579 +4 ☔ View full report in Codecov by Sentry. |
0493dcf to
4a9f9dd
Compare
99e4bf3 to
97056b8
Compare
iwahbe
approved these changes
Jan 17, 2025
4a9f9dd to
11d0a7f
Compare
97056b8 to
f73e706
Compare
f73e706 to
b961383
Compare
Contributor
|
This PR has been shipped in release v3.102.0. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Set and List Diff tests to use the generic diff utility functions and types introduced in #2829. This should make the tests more maintainable and more in-line with what other tests do.
861ec1f contains the changes:
diffSchemaValueMakerPairanddiffScenariotypes for their tests.propfor top-level properties andnested_propfor nested ones, like the rest of the tests.runSDKv2TestMatrixtest function.valueMakerfunctions fromvalue_makers.goto return amap[string]cty.Valueinstead of acty.Valuewhich needs to be transformed further after.list element removed, where the order of the elements was wrong in the changed values.f800d2d contains the test recordings.
Related to #2788
Related to #2789