Skip to content

Conversation

@Frassle
Copy link
Member

@Frassle Frassle commented Oct 31, 2025

A (probably better) alternative to #3227. Terraform treats ephemeral resources more like data sources, so rather than exposing these as resources this PR exposes them as invokes.

Questions

  1. Are we ok just keeping track of private state and renewals within the bridge process? Seems to work fine, and the engine does promise providers can be stateful.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 59.76096% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.67%. Comparing base (4c91969) to head (bbe2da4).

Files with missing lines Patch % Lines
pkg/pf/tfbridge/provider_invoke.go 62.31% 18 Missing and 8 partials ⚠️
...g/pf/internal/schemashim/ephemeral_resource_map.go 42.42% 19 Missing ⚠️
pkg/pf/tfbridge/naming.go 0.00% 12 Missing ⚠️
pkg/pf/proto/protov6.go 0.00% 6 Missing ⚠️
pkg/pf/tfbridge/provider_ephemeral_resources.go 76.00% 3 Missing and 3 partials ⚠️
pkg/tfbridge/info/info.go 25.00% 5 Missing and 1 partial ⚠️
pkg/convert/encoding.go 66.66% 2 Missing and 2 partials ⚠️
pkg/pf/tfbridge/provider.go 77.77% 2 Missing and 2 partials ⚠️
pkg/pf/internal/pfutils/ephemeral_resources.go 88.46% 2 Missing and 1 partial ⚠️
pkg/pf/proto/runtypes.go 50.00% 2 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3229      +/-   ##
==========================================
+ Coverage   68.62%   69.67%   +1.05%     
==========================================
  Files         338      340       +2     
  Lines       44181    36684    -7497     
==========================================
- Hits        30318    25559    -4759     
+ Misses      12128     9371    -2757     
- Partials     1735     1754      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant