Skip to content

Try removing some TODOs for issues that have been marked fixed #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Try removing some TODOs for issues that have been marked fixed #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions tests/acc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,14 +483,6 @@ func TestGenerateTerraformAwsModulesSDKs(t *testing.T) {
t.Run("typescript", func(t *testing.T) {
d := dest("node")
pulumiConvert(t, localProviderBinPath, pclDir, d, "typescript", generateOnly)

// TODO[github.com/pulumi#19616] not quite working right and to avoid issues we need to clean up
// artifacts of `pulumi install`.
err := os.RemoveAll(filepath.Join(d, "node_modules"))
require.NoError(t, err)

err = os.RemoveAll(filepath.Join(d, "package-lock.json"))
require.NoError(t, err)
})

t.Run("python", func(t *testing.T) {
Expand All @@ -500,7 +492,6 @@ func TestGenerateTerraformAwsModulesSDKs(t *testing.T) {
})

t.Run("dotnet", func(t *testing.T) {
t.Skip("TODO[pulumi/pulumi-terraform-module#77] the project is missing the SDK")
d := dest("dotnet")
pulumiConvert(t, localProviderBinPath, pclDir, d, "dotnet", generateOnly)
})
Expand Down
Loading